Re: [Cbe-oss-dev] [PATCH 11/13] cell: split out board specific files

[Segher Boessenkool]

> >  config SPIDER_NET
> >  	tristate "Spider Gigabit Ethernet driver"
> > -	depends on PCI && PPC_CELL
> > +	depends on PCI && PPC_IBM_CELL_BLADE
> >  	select FW_LOADER
> >  	help
> >  	  This driver supports the Gigabit Ethernet chips present on the
>
> Hmm, I'm also no longer sure if this is right. In theory, spidernet
> could be used in all sorts of products, wether they are using the
> same bridge chip or just the gigabit ethernet macro from it.
>
> For now, I guess you can just leave this one alone if you respin
> the patch another time. It's disabled by default, so the dependency
> can be updated the next time we get a user in _addition_ to PPC_CELL.

Is there any reason the driver wouldn't build and/or run on other
platforms?  If so, fix it.  If not, just make it

	depends on PCI

?


Segher

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/