Re: [PATCH 7/7] uts namespaces: Implement CLONE_NEWUTS flag

[Eric W. Biederman]

Andi Kleen <ak@xxxxxxx> writes:

> "Serge E. Hallyn" <serue@xxxxxxxxxx> writes:
>
>> Implement a CLONE_NEWUTS flag, and use it at clone and sys_unshare.
>
> I still think it's a design mistake to add zillions of pointers to task_struct
> for every possible kernel object. Going through a proxy datastructure to 
> merge common cases would be much better.

The design point is not every kernel object.  The target is one
per namespace.  Or more usefully one per logical chunk of the kernel.

The UTS namespace is by far the smallest of these pieces.

The kernel networking stack is probably the largest.

At last count there were about 7 of these, enough so that the few
remaining clone bits would be sufficient.

Do you disagree that to be able to implement this properly we
need to take small steps?

Are there any semantic differences between a clone bit and what you
are proposing?

If it is just an internal implementation detail do you have a clear
suggestion on how to implement this?  Possibly illustrated by the
thread flags that are already in this situation, and more likely
to always share everything.

Except for reducing reference counting I really don't see where
we could have a marked improvement.  I also don't see us closing
the door to that kind of implementation at this point, but instead
taking the simple path.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/