Re: [PATCH 7/7] uts namespaces: Implement CLONE_NEWUTS flag

[Eric W. Biederman]

Dave Hansen <haveblue@xxxxxxxxxx> writes:

> On Mon, 2006-05-01 at 14:53 -0500, Serge E. Hallyn wrote:
>> +struct uts_namespace *clone_uts_ns(struct uts_namespace *old_ns)
>> +{
>> +	struct uts_namespace *ns;
>> +
>> +	ns = kmalloc(sizeof(struct uts_namespace), GFP_KERNEL);
>> +	if (ns) {
>> +		memcpy(&ns->name, &old_ns->name, sizeof(ns->name));
>> +		kref_init(&ns->kref);
>> +	}
>> +	return ns;
>> +}
>
> Very small nit...
>
> Would this memcpy be more appropriate as a strncpy()?

Nope.  It is several strings.  Although a different field name
for the old utsname structure might be called for to keep people
from getting confused.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/