Re: Add a "enable" sysfs attribute to the pci devices to allow userspace (Xorg) to enable devices without doing foul direct access

[Adam Belay]

On Fri, May 05, 2006 at 01:26:03PM -0700, Greg KH wrote:
> On Fri, May 05, 2006 at 04:14:00PM -0400, Jon Smirl wrote:
> > I would like to see other design alternatives considered on this
> > issue. The 'enable' attribute has a clear problem in that you can't
> > tell which user space program is trying to control the device.
> > Multiple programs accessing the video hardware with poor coordination
> > is already the source of many problems.
> 
> Who cares who "enabled" the device.  Remember, the majority of PCI
> devices in the system are not video ones.  Lots of other types of
> devices want this ability to enable PCI devices from userspace.  I've
> been talking with some people about how to properly write PCI drivers in
> userspace, and this attribute is a needed part of it.
> 
> And if X gets enabling the device wrong, again, who cares, it's not a
> kernel issue. :)
> 
> thanks,
> 
> greg k-h
> -

The main issue I see with the "enable" sysfs attribute is that it doesn't
mediate who has ownership of the device's state and context, as Jon has
mentioned.  As a result, userspace might, not knowing any better, disable
the device while its kernel driver is trying to access it, or a number of
other fatal senarios.

However, I understand that video is not the only issue at hand, and there is
some interest in userspace PCI drivers.  At the very least, we should prevent
any writing to the "enable" attribute if a kernelspace driver is bound to
the device.  This patch completely ignores such issues.

We might want to take this a step further and create a generic PCI userspace
kernel driver that exports knobs such as "enable" in sysfs and also handles
some baseline suspend/resume behavior and whatever else is needed for
userspace drivers.  This will ensure that the kernel is aware that the
hardware is owned by a userspace driver, and it will make it clear to a user
app that it is allowed to control the device.

Thanks,
Adam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/