Re: [PATCH 3/10] explict migrate tasks for cpu removal

[Ingo Molnar]

* Shaohua Li <shaohua.li@xxxxxxxxx> wrote:

> Make cpu_down explictly migrate tasks off dead cpus, this is to fix a 
> dead lock in bulk cpu hotremoval (An example of the deadlock is one 
> dead cpu is notifing udev the cpu is dead and khelper thread is on 
> another dead cpu). Detail info is in the code.

looks good, except some style issues:

> +	/* No need to migrate the tasks: it was best-effort if
> +	 * they didn't do lock_cpu_hotplug().  Just wake up
> +	 * the requestors. */

needs proper comment style.

> +		migration_req_t *req;
> +		req = list_entry(rq->migration_queue.next,
> +				 migration_req_t, list);

missing newline between variables and code.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/