Re: [patch] add new uevent

[Alexey Dobriyan]

On Mon, May 08, 2006 at 10:24:49AM -0700, Kristen Accardi wrote:
> On Sat, 2006-05-06 at 02:22 +0400, Alexey Dobriyan wrote:
> > On Fri, May 05, 2006 at 03:13:36PM -0700, Kristen Accardi wrote:
> > > Add dock uevents so that userspace can be notified of dock and undock
> > > events.
> >
> > > --- 2.6-git-kca2.orig/include/linux/kobject.h
> > > +++ 2.6-git-kca2/include/linux/kobject.h
> > > @@ -46,6 +46,8 @@ enum kobject_action {
> > >  	KOBJ_UMOUNT	= (__force kobject_action_t) 0x05,	/* umount event for block devices (broken) */
> > >  	KOBJ_OFFLINE	= (__force kobject_action_t) 0x06,	/* device offline */
> > >  	KOBJ_ONLINE	= (__force kobject_action_t) 0x07,	/* device online */
> > > +	KOBJ_UNDOCK	= (__force kobject_action_t) 0x08, 	/* undocking */
> > > +	KOBJ_DOCK	= (__force kobject_action_t) 0x09,	/* dock */
> > >  };
> > >
> > >  struct kobject {
> > > --- 2.6-git-kca2.orig/lib/kobject_uevent.c
> > > +++ 2.6-git-kca2/lib/kobject_uevent.c
> > > @@ -48,6 +48,10 @@ static char *action_to_string(enum kobje
> > >  		return "offline";
> > >  	case KOBJ_ONLINE:
> > >  		return "online";
> > > +	case KOBJ_DOCK:
> > > +		return "dock";
> > > +	case KOBJ_UNDOCK:
> > > +		return "undock";
> > >  	default:
> > >  		return NULL;
> > >  	}
> >
> > Where exactly are you going to generate them?
>
> Hi Alexey,
> These events will be generated from the dock driver.  The patch for this
> will be submitted in the next day or 2 (assuming everyone is ok with
> adding these events).

Without seeing actual driver it's impossible to say OK or not.

Post the driver when you're ready and make those two chunks a part of whole
patch.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/