Re: + two-additions-to-linux-documentation-ioctl-numbertxt.patch added to -mm tree

From: Alexey Dobriyan
Date: Mon May 08 2006 - 17:23:21 EST


On Mon, May 08, 2006 at 10:48:40AM -0700, akpm@xxxxxxxx wrote:
> two additions to ./linux/Documentation/ioctl-number.txt

> --- devel/Documentation/ioctl-number.txt~two-additions-to-linux-documentation-ioctl-numbertxt
> +++ devel-akpm/Documentation/ioctl-number.txt
> @@ -85,7 +85,9 @@ Code Seq# Include File Comments

> 'C' all linux/soundcard.h
> 'D' all asm-s390/dasd.h
> +'E' all linux/input.h

This one is good.

> 'F' all linux/fb.h
> +'H' all linux/hiddev.h

Quick grep shows 'H' namespace is kinda-sorta divided between some bluetooth
headers, hiddev.h (as was correctly noted) and sound SNDRV_*. Of course,
it's worse because ALSA and hiddev.h ioctls conflict pretty often.

Was second column "Seq#" meant to be central registration point of new
ioctls? If it's, boundaries are not obeyed and comments like

/*
* IOCTLS (0x00 - 0x7f)
*/

should be removed probably from everywhere to not give false sense of
ownership TOGETHER with rejecting every new conflicting ioctl.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/