Re: [PATCH] hptiop: HighPoint RocketRAID 3xxx controller driver

[Alexey Dobriyan]

On Tue, May 09, 2006 at 02:28:31PM -0700, Allen wrote:
> This is the first time driver submission of HighPoint RocketRAID 3xxx
> controllers.

Please, use sane mailer. Sane means:
* it shouldn't convert tab to space
* it shouldn't wrap long lines

> +static struct class_device_attribute hptiop_attr_ioctl = {
> + .attr = {
> +  .name = "ioctl",
> +  .mode = S_IWUSR,
> + },
> + .store = hptiop_store_ioctl
> +};

No way in hell. ioctls are done by defining ->ioctl method.
struct scsi_host_template has one. struct file_operations has one.
Quick grepping shows some subsystems also exctracted ->ioctl.

That plethora of HPT_IOCTL_* defines, where are you using them? What
arguments are passed in and out?

s/vender/vendor/ somewhere, also

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/