Re: [PATCH -mm] megaraid gcc 4.1 warning fix

[Alan Cox]

On Maw, 2006-05-09 at 19:56 -0700, Daniel Walker wrote:
> Fixes the following warning,
> 
> drivers/scsi/megaraid.c: In function âissue_scbâ:
> drivers/scsi/megaraid.c:1153: warning: passing argument 2 of âwritelâ makes pointer from integer without a cast

And adds an exploitable memory leak. Please don't fix "bugs" blindly but
check that the error path still releases all the relevant resources.

In this case its probably sufficient just to set rval and fal through,
but each one needs to be reviewed properly.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/