Re: [patch 2/6] New Generic HW RNG

From: Greg KH
Date: Wed May 10 2006 - 17:03:02 EST


On Sun, May 07, 2006 at 03:16:08PM +0200, Michael Buesch wrote:
> On Sunday 07 May 2006 15:03, you wrote:
> > > + list_for_each_entry(rng, &rng_list, list) {
> > > + if (strncmp(rng->name, buf, len) == 0) {
> >
> > This will match if the passed string is just a prefix of rng->name.
> > Apparently sysfs guarantees that the buffer passed to ->store will be
> > NUL-terminated, so this should be just a strcmp().
>
> I am not sure if it is guaranteed NUL terminated. Greg?
> But I will look into this.

Yes it will be.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/