Re: Bug while executing : cat /proc/iomem on 2.6.17-rc1/rc2

[Sharyathi Nagesh]

I was able to replicate the Bug, even when all the drivers are built into the kernel. 
It looks like while traversing through p->parent field of resource structure is leading to NULL pointer. 
Would it be appropriate to make the following code change. 
	But I found cat /proc/iomem hangs after line kernel data..

--- kernel/resource.c.old       2006-05-11 05:29:33.000000000 -0700
+++ kernel/resource.c   2006-05-11 05:29:58.000000000 -0700
@@ -81,7 +81,7 @@ static int r_show(struct seq_file *m, vo
        int depth;

        for (depth = 0, p = r; depth < MAX_IORES_LEVEL; depth++, p = p->parent){
-               if (p->parent == root)
+               if (p->parent == root || p->parent == NULL)
                        break;
        }
        seq_printf(m, "%*s%0*lx-%0*lx : %s\n",
Regards
Sharyathi Nagesh

On Tue, 2006-04-25 at 12:48 +0200, Arjan van de Ven wrote:
> On Tue, 2006-04-25 at 16:13 +0530, Sachin Sant wrote:
> > I found this following problem while executing cat/proc/iomem. The 
> > command causes following BUG.
> > 
> > x236:/linux-2.6.17-rc1/fs # cat /proc/iomem
> > Segmentation fault
> 
> 
> this tends to be a driver bug; could you compile all the drivers you
> need as module, and then try to not load them as much as possible. See
> if it still crashes, if not, load the rest one at a time until it
> crashes, and then you've found the culprit :)
> 
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/