Re: fix compiler warning in ip_nat_standalone.c
From: Al Viro
Date: Thu May 11 2006 - 12:18:29 EST
On Thu, May 11, 2006 at 05:55:37PM +0200, J?rn Engel wrote:
> On Thu, 11 May 2006 17:29:48 +0200, Rik Bobbaers wrote:
> >
> > i just made small patch that fixes a compiler warning:
>
> Just in case Al didn't make it clear enough in the recent thread:
>
> You cannot fix a compiler warning!
>
> Either the code is wrong or it is right. A compiler warning can
> indicate that code is wrong, or it is a false positive. If the code
> is wrong, fix the _code_.
Which is what the patch does, AFAICS. What's the problem in this case?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/