Re: [patch] SMP alternatives: skip with UP kernels.

[Andi Kleen]

Mikael Pettersson <mikpe@xxxxxxxx> writes:

> On Thu, 11 May 2006 14:13:22 +0200, Gerd Hoffmann wrote:
> >+	if (0 == (__smp_alt_end - __smp_alt_begin))
> >+		return; /* no tables, nothing to patch (UP kernel) */
> 
> That's an unnecessarily obscure way of stating the obvious:
> 
> 	if (__smp_alt_end == __smp_alt_begin)

iirc ISO-C guarantees that symbols have different values and the
optimizer could possibly make use of that fact. So you might actually
need some RELOC_HIDE()s to make this safe.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/