Re: [patch 9/9] Add bcm43xx HW RNG support

[Johannes Berg]

On Fri, 2006-05-12 at 18:16 +0300, Denis Vlasenko wrote:

> Didn't you mean
> 
> 	*(u16*)data = bcm43xx_read16(bcm, BCM43xx_MMIO_RNG); ?
> 
> > +	bcm43xx_unlock(bcm, flags);
> > +
> > +	return (sizeof(u16));
> > +}

I'm not the expert, but looking at patch 2 I'd say no, because one byte
is copied out and then the value is right-shifted, so it is always
treated as a u32 where only 'size' bytes are valid starting with the
lower bytes.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part