Re: [patch 3/9] Add Intel HW RNG driver

[Michael Buesch]

On Friday 12 May 2006 13:08, you wrote:
> > +static struct pci_device_id pci_tbl[] = {
> 
> Should be const.

Sure, will fix that for every driver.

> > +	for_each_pci_dev(pdev) {
> > +		ent = pci_match_id(pci_tbl, pdev);
> > +		if (ent)
> > +			goto found;
> > +	}
> > +	/* Device not found. */
> > +	goto out;
> 
> 	if (!pci_dev_present(pci_tbl))
> 		goto out;

Good idea. I just copied the code from the old driver.

> > +	err = hwrng_register(&intel_rng);
> > +	if (err) {
> > +		printk(KERN_ERR PFX "RNG registering failed (%d)\n",
> > +		       err);
> > +		goto out;
> 
> 		goto err_unmap;

oops.

-- 
Greetings Michael.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/