Re: [RFC PATCH 24/35] Add support for Xen event channels.

[Andrew Morton]

On Tue, 09 May 2006 00:00:24 -0700
Chris Wright <chrisw@xxxxxxxxxxxx> wrote:

> +void __init init_IRQ(void)
> +{
> +	int i;
> +	int cpu;
> +
> +	irq_ctx_init(0);
> +
> +	spin_lock_init(&irq_mapping_update_lock);

May as well initialise this at compile time.

> +	init_evtchn_cpu_bindings();
> +
> +	/* No VIRQ or IPI bindings. */
> +	for (cpu = 0; cpu < NR_CPUS; cpu++) {

Using NR_CPUS is a little...  old-fashioned.  I'd suggest a sweep through
all the Xen code, look for places where it should be using
for_each_foo_cpu().



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/