Re: [PATCH] Silly bitmap size accounting fix

[Nick Piggin]

Takashi Iwai wrote:
> At Sat, 13 May 2006 10:12:11 -0400 (EDT),
> Steven Rostedt wrote:
>
> > Index: linux-2.6.17-rc3-mm1/kernel/sched.c
> > ===================================================================
> > --- linux-2.6.17-rc3-mm1.orig/kernel/sched.c	2006-05-12 04:02:32.000000000 -0400
> > +++ linux-2.6.17-rc3-mm1/kernel/sched.c	2006-05-13 10:09:15.000000000 -0400
> > @@ -192,6 +192,10 @@ static inline unsigned int task_timeslic
> >  * These are the runqueue data structures:
> >  */
> >
> > +/*
> > + * Calculate BITMAP_SIZE.
> > + *  The bitmask holds MAX_PRIO bits + 1 for the delimiter.
> > + */
> > #define BITMAP_SIZE ((((MAX_PRIO+1+7)/8)+sizeof(long)-1)/sizeof(long))
>
>
> What's wrong with BITS_TO_LONG(MAX_PRIO + 1) ?
>
> Or, using DECLARE_BITMAP() in struct prio_array would be easier...

Yes that sounds even better.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/