Re: [PATCH 2.6.17-rc4 6/6] Remove some of the kmemleak false positives

[Catalin Marinas]

Jesper Juhl wrote:
> On 13/05/06, Catalin Marinas <catalin.marinas@xxxxxxxxx> wrote:
>> +#ifdef CONFIG_DEBUG_MEMLEAK
>> +               /* avoid a false alarm. That's not a memory leak */
>> +               memleak_free(out);
>> +#endif
> 
> 
> Hmm, so eventually we are going to end up with a bunch of ussgly #ifdef
> CONFIG_DEBUG_MEMLEAK's all over the place?
> 
> Wouldn't it be better to just make memleak_free() an empty stub in the
> !CONFIG_DEBUG_MEMLEAK case?

Yes, I'll make empty stubs (Paul suggested this as well).

Catalin
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/