Re: [PATCH] ide_cs: Make ide_cs work with the memory space of CF-Cardsif IO space is not available (2nd revision)

[Thomas Kleffel (maintech GmbH)]

Hi,

> Thomas Kleffel (maintech GmbH) wrote:
>  
>
> > +    if(is_mmio) 
> > +    	my_outb = outb_mem;
> > +    else
> > +    	my_outb = outb_io;
> >    
>
> David Vrabel wrote:
>  
>
> > Shouldn't you convert ide_cs to use iowrite8 (and friends) instead of
> > doing this?
> >    
>
>
> Actually, I think even better to use the primitives from ide-iops.c ?
>  
They're declared static in ide-iops.c and I can't get them out of the 
ide_hwif_t struct as it is initialized after I need the primitives.

I think the simplest way is to use my own primitives.

Thomas



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/