Re: [PATCH] i386/x86-64 Add nmi watchdog support for new Intel CPUs

[Venkatesh Pallipadi]

On Sun, May 14, 2006 at 07:11:01PM -0700, Andrew Morton wrote:
> Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx> wrote:
> >
> > --- linux-2.6.17-rc4/arch/i386/kernel/nmi.c	2006-05-11 17:23:13.000000000 -0700
> >  +++ linux-2.6.17-rc4-nmi/arch/i386/kernel/nmi.c	2006-05-12 17:47:48.000000000 -0700
> >   
> > ...
> >
> >  +static void disable_intel_arch_watchdog(void)
> 
> Should this code be moved to arch/i386/kernel/cpu/intel.c?

I am not sure. The other watchdog setup functions p3, p4, k7 are all
in nmi.c file and thats the reason I kept the new function in the same file too.
Also, as this is specific to watchdog event, it won't be called by anyone else.

If you are thinking of putting these disable and enable functions in same place so
that we can share it across i386/x86_64, we can put it in intel_cacheinfo or create
a new file for this. There is one line difference between i386 and x86_64 enable
functions due to a macro getting used in i386 version. So, we will have to workaround 
that to make this code shared.

Thanks,
Venki
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/