Re: [PATCH 53 of 53] ipath - add memory barrier when waiting for writes

[Roland Dreier]

 >  static void i2c_wait_for_writes(struct ipath_devdata *dd)
 >  {
 > +	mb();
 >  	(void)ipath_read_kreg32(dd, dd->ipath_kregs->kr_scratch);
 >  }

This needs a comment explaining why it's needed.  A memory barrier
before a readl() looks very strange since readl() should be ordered anyway.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/