Re: Add Geode HW RNG driver

[Jordan Crouse]

On 12/05/06 22:46 +0200, "Michael Buesch" wrote:
> On Friday 12 May 2006 13:05, you wrote:
> > mb@xxxxxxxxx wrote:
> > > Signed-off-by: Michael Buesch <mb@xxxxxxxxx>
> > > Index: hwrng/drivers/char/hw_random/Kconfig
> > > ===================================================================
> > > --- hwrng.orig/drivers/char/hw_random/Kconfig	2006-05-08 00:11:59.000000000 +0200
> > > +++ hwrng/drivers/char/hw_random/Kconfig	2006-05-08 00:12:08.000000000 +0200
> > > @@ -35,3 +35,16 @@
> > >  	  module will be called amd-rng.
> > >  
> > >  	  If unsure, say Y.
> > > +
> > > +config HW_RANDOM_GEODE
> > > +	tristate "AMD Geode HW Random Number Generator support"
> > > +	depends on HW_RANDOM && (X86 || IA64) && PCI
> >                                      ^^^^^^^
> > IA64?
> 
> I have no idea. I neither wrote the driver, nor do I have the device.
> So, drop IA64?

Wow - where did that come from?  Yeah, drop it!

> > > +	default y
> > > +	---help---
> > > +	  This driver provides kernel-side support for the Random Number
> > > +	  Generator hardware found on AMD Geode based motherboards.
> > > +
> > > +	  To compile this driver as a module, choose M here: the
> > > +	  module will be called geode-rng.
> > 
> > You need to state which members of the Geode family have this hardware.
> >  e.g., Is it only the Geode LX CPUs?
> 
> Well, no idea. It was not stated in the existing old help text either.

Its just the Geode LX - that help text should be more specific in that
regard.

Regards,
Jordan

--
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/