[PATCH] 2.6.17-rc4-mm1 - kbuild wierdness with EXPORT_SYMBOL_GPL

[Valdis . Kletnieks]

It looks like a buggy comparison down in the guts of
kbuild-export-type-enhancement-to-modpostc.patch - it's doing
something really odd when it hits a EXPORT_SYMBOL_GPL.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@xxxxxx>
---
Proposed fix (with an added debugging warning Just In Case:

--- linux-2.6.17-rc4-mm1/scripts/mod/modpost.c.whatdied	2006-05-15 13:50:13.000000000 -0400
+++ linux-2.6.17-rc4-mm1/scripts/mod/modpost.c	2006-05-15 14:52:13.000000000 -0400
@@ -1194,12 +1194,14 @@
 					*d != '\0')
 			goto fail;
 
-		if ((strcmp(export, "EXPORT_SYMBOL_GPL")))
+		if ((strcmp(export, "EXPORT_SYMBOL_GPL") == 0))
 			export_type = 1;
 		else if(strcmp(export, "EXPORT_SYMBOL") == 0)
 			export_type = 0;
-		else
+		else {
+			warn("Odd symbol export=%s symname=%s modname=%s\n",export,symname,modname);
 			goto fail;
+		}
 
 		if (!(mod = find_module(modname))) {
 			if (is_vmlinux(modname)) {

Attachment: pgp00000.pgp
Description: PGP signature