Re: [PATCH] Register sysfs file for hotpluged new node

From: Dave Hansen
Date: Tue May 16 2006 - 10:52:32 EST


On Tue, 2006-05-16 at 21:23 +0900, Yasunori Goto wrote:
> + /*
> + * register this node to sysfs.
> + * this is depends on topology. So each arch has its own.
> + */
> + if (new_pgdat){
> + ret = arch_register_node(nid);
> + BUG_ON(ret);
> + }

Please don't do BUG_ON()s for things like this. Memory hotplug _should_
handle failures from top to bottom and not screw you over. It isn't a
crime or a bug to be out of memory.

Have you run this past the ppc maintainers?

-- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/