Re: [PATCH] selinux: endian fix

[Al Viro]

On Tue, May 16, 2006 at 06:24:14PM +0200, Andreas Schwab wrote:
> James Morris <jmorris@xxxxxxxxx> writes:
> 
> > On Tue, 16 May 2006, Alexey Dobriyan wrote:
> >
> >> Signed-off-by: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> >
> > Hmm, I'm certain this was tested (perhaps on a BE machine, though).
> 
> ntohs and htons are identical operations.  Either you swap or you don't,
> but there is only one way to swap a short.

Indeed, but that kind of crap still deserves a fix - same result, but
use that kind of misuse is begging for bugs later on.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/