Re: [patch] add input_enable_device()

[Chase Venters]

On Tue, 16 May 2006, Stas Sergeev wrote:

> Hello.
>
> Andrew Morton wrote:
> >  iirc it had to do with the pc-speaker driver, but I don't seem to be able
> >  to locate the original email.
> OK, sorry, I haven't realized its important.
>
> ---
> The patch below adds input_enable_device() and input_disable_device()
> to the input subsystem, that allows to enable and disable the input
> devices. The reason to have it, is the snd-pcsp PC-Speaker driver in
> an ALSA tree that needs an ability to disable the pcspkr driver.
>
> Signed-off-by: Stas Sergeev <stsp@xxxxxxxx>
> CC:  Dmitry Torokhov <dtor_core@xxxxxxxxxxxxx>
> CC:  Vojtech Pavlik <vojtech@xxxxxxx>

> --- a/include/linux/input.h	2006-04-05 17:10:01.000000000 +0400
> +++ b/include/linux/input.h	2006-04-05 17:36:49.000000000 +0400
> @@ -878,7 +878,7 @@
>
>  	struct pt_regs *regs;
>  	int state;
> -
> +	int disabled;
>  	int sync;
>
>  	int abs[ABS_MAX + 1];

Why eat an entire word here? It seems we already have a "dynalloc" 
boolean/int... perhaps some of these things could be rolled up into a 
bitfield.

Cheers,
Chase
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/