Re: [RFC] [Patch 7/8] statistics infrastructure - exploitation prerequisite

From: Nick Piggin
Date: Tue May 16 2006 - 22:32:26 EST


Andrew Morton wrote:

Martin Peschke <mp3@xxxxxxxxxx> wrote:

need sched_clock for latency statistics


sched_clock() probably isn't suitable for this application. It's a
scheduler thing and has a number of accuracy problems.

But I thought we discussed this last time around? Maybe not.

Maybe you've considered sched_clock()'s drawbacks and you've decided
they're all acceptable. If so, the changelog should have described the
reasoning.


Yeah; please, no more users of sched_clock(). Definitely don't export.

Even if it is what you want today (which it probably isn't), the scheduler
might want the ability to change it at short notice, depending on new
algorithms / new hardware etc. in future.

Make a new function if none of the suggested alternatives work.

--

Send instant messages to your online friends http://au.messenger.yahoo.com -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/