Re: [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_writeinstead

[Ian Kent]

Christoph Hellwig wrote:
> On Sun, May 21, 2006 at 06:00:37PM -0700, Andrew Morton wrote:
> > Badari Pulavarty <pbadari@xxxxxxxxxx> wrote:
> > > This patch removes readv() and writev() methods and replaces
> > >  them with aio_read()/aio_write() methods.
> > And it breaks autofs4
> >
> > autofs: pipe file descriptor does not contain proper ops
>
> this comes because the autofs4 pipe fd doesn't have a write file
> operations.
>
> Badari do you remember any place in your patches where you didn't
> add do_sync_write for a file_operations instance?
>
> Ian, what kind of file is the autofs4 pipe?  is it a named pipe or
> a fifo or a "real" file?

The autofs4 fill_super does an fget on a pipe file handle passed in the 
mount options. It uses the write method of the returned file struct to 
send packets back to the daemon. The fill_super method checks to see if 
there is a write method present in the returned file struct and emits 
this message if it's not found.

Ian


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/