Re: [PATCH 2/4] Remove readv/writev methods and useaio_read/aio_write instead

From: Andrew Morton
Date: Mon May 22 2006 - 05:35:26 EST


Andrew Morton <akpm@xxxxxxxx> wrote:
>
> Christoph Hellwig <hch@xxxxxx> wrote:
> >
> > On Sun, May 21, 2006 at 06:00:37PM -0700, Andrew Morton wrote:
> > > Badari Pulavarty <pbadari@xxxxxxxxxx> wrote:
> > > >
> > > > This patch removes readv() and writev() methods and replaces
> > > > them with aio_read()/aio_write() methods.
> > >
> > > And it breaks autofs4
> > >
> > > autofs: pipe file descriptor does not contain proper ops
> >
> > this comes because the autofs4 pipe fd doesn't have a write file
> > operations.
> >
>
> Note that fs/autofs/inode.c does the same thing.

The loop driver plays with file_operations.write() also. The code should
be reviewed and tested against filesystems which use LO_FLAGS_USE_AOPS as
well as against those which do not, please.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/