Re: [PATCH 5/6] nfs: check all iov segments for correct memory access rights

From: Andi Kleen
Date: Mon May 22 2006 - 07:52:09 EST


Chuck Lever <cel@xxxxxxxxxx> writes:

> Add Badari's function to check access for all the segments in a passed-in
> iov. We can use the total byte count later.

It seems bogus to me because there is no big reason the access_ok
can't be done later together with the real access. After all the
real access has to check anyways to handle unmapped pages.

To pass checking is more error prone than single pass.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/