Re: [PATCH 2.6.17-rc5-mm2 17/18] sbp2: provide helptext forCONFIG_IEEE1394_SBP2_PHYS_DMA and mark it experimental

[Ben Collins]

On Sat, 2006-06-03 at 01:21 +0200, Stefan Richter wrote:
> Ben Collins wrote:
> > Rather it be in the config. Plus your suggestion still makes it
> > unusable :)
> 
> Right. But only if ohci1394 is loaded with phys_dma=0 or a controller 
> without phys DMA is used. Only these conditions let sbp2 run into the 
> routine which currently uses bus_to_virt.

Sure, that's not a problem. I just don't think we should make the option
available on platforms where it cannot work at all. No need to add to
the confusion.

> Would '&& (X86_32 || PPC_32)' work too?

Perfect.

-- 
Ubuntu     - http://www.ubuntu.com/
Debian     - http://www.debian.org/
Linux 1394 - http://www.linux1394.org/
SwissDisk  - http://www.swissdisk.com/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/