Re: [PATCH 1/4] Twofish cipher - split out common c code

[Herbert Xu]

On Fri, Jun 16, 2006 at 01:58:52PM +0200, Joachim Fritschi wrote:
>
> I have done the changes you requested. twofish and twofish_common are now 2
> seperate modules. twofish_common is hidden from the user and can be shared by 
> both generic-c and the asm implementation.

Thanks, but unfortunately your patch doesn't apply for me.  You should
base your work on the tree at

git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/

  
> +config CRYPTO_TWOFISH_COMMON
> +        tristate	
> +        depends on CRYPTO
> +        help
> +	  Common parts of the Twofish cipher algorithm shared by the 
> +	  generic c and the assembler implementations.

Please drop the help (it's not meant to be visible) and add a 'default n'
instead.

> diff -uprN linux-2.6.17-rc5/crypto/twofish_common.c linux-2.6.17-rc5.twofish/crypto/twofish_common.c
> --- linux-2.6.17-rc5/crypto/twofish_common.c	1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.17-rc5.twofish/crypto/twofish_common.c	2006-06-11 15:58:20.319984126 +0200
> @@ -0,0 +1,740 @@

...

> +static const u8 q0[256] = {
> +   0xA9, 0x67, 0xB3, 0xE8, 0x04, 0xFD, 0xA3, 0x76, 0x9A, 0x92, 0x80, 0x78,

Please take the opportunity to reformat this to use tabs.

> diff -uprN linux-2.6.17-rc5/include/crypto/twofish.h linux-2.6.17-rc5.twofish/include/crypto/twofish.h
> --- linux-2.6.17-rc5/include/crypto/twofish.h	1970-01-01 01:00:00.000000000 +0100
> +++ linux-2.6.17-rc5.twofish/include/crypto/twofish.h	2006-06-11 15:58:20.319984126 +0200
> @@ -0,0 +1,14 @@

Please add the usual preamble (see include/linux/xfrm.h for example).

> +int twofish_setkey(void *cx, const u8 *key,unsigned int key_len, u32 *flags);
					      ^ needs space here

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/