Re: [patch] mspec

From: Randy.Dunlap
Date: Mon Jun 19 2006 - 11:54:49 EST


On 19 Jun 2006 05:20:23 -0400 Jes Sorensen wrote:

> Hi,
>
> Since today is the day of do_no_pfn, it is obviously also the time for
> mspec! Here we go :)

Just minor stuff:

> +MODULE_AUTHOR("Silicon Graphics, Inc.");
> +MODULE_DESCRIPTION("Driver for SGI SN special memory operations");
> +MODULE_LICENSE("GPL");
> +MODULE_INFO(supported, "external");

What does that last line mean? what does "external" mean?
There are no other source files in the 2.6.17 tree that say
anything like that.

And of the 1800+ MODULE_AUTHOR() lines, SGI seems to be
dominant is using company instead of a person for AUTHOR.
Yes, there are a few others as well.
module.h says:
/* Author, ideally of form NAME <EMAIL>[, NAME <EMAIL>]*[ and NAME <EMAIL>] */

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/