Re: [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default

[Theodore Tso]

On Mon, Jun 19, 2006 at 09:01:46AM -0700, Joel Becker wrote:
> 
> 	I assume you meant sb->s_blksize.  osb is a private structure
> hanging off of sb->s_fs_info.

Yep, mea culpa.

> 	I have to say, having sb->s_blocksize and sb->s_blksize might be
> a little confusing.

How strongly do you feel about reporting stat.st_blksize out to be the
clustersize?  Keeping in mind that if you report a value which is too
big, /bin/cp will start coredumping....

If I take Christoph's suggestion of simply removing sb->s_blksize
altogether, and forcing filesystems that want to return a non-default
value for stat.st_blksize to supply their own filesystem-specific
getattr, will you mind terribly?

						- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/