Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

From: Herbert Xu
Date: Tue Jun 20 2006 - 07:13:38 EST


On Mon, Jun 19, 2006 at 04:13:01PM +0200, Joachim Fritschi wrote:
> This patch is now based on the cryptodev tree using the new cryptoapi (crypto tfm
> instead of the crypto ctx as parameter).
>
> The module passed the tcrypt tests and testscripts.
>
> Signed-off-by: Joachim Fritschi <jfritschi@xxxxxxxxxx>

Thanks Joachim. I've applied all four patches. I had to add wrappers
around the twofish assembly routines because asmlinkage may differ from
the normal C calling convention. It should get optimised away to just
a jump if the conventions are identical.

BTW Andi, I think it might be better to have the x86-64 patch sit in the
cryptodev tree rather than x86-64 because it won't even compile without
the previous patches. If you really want to, I can leave out the x86-64
one in particular for you to merge after the others go upstream.

Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/