Re: LibPATA/ATA Errors Continue - Will there be a fix for this?

[Mark Lord]

Al Boldi wrote:
> I once sent a patch to -mm:
..
> > > -#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==(good))
> > > +#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==((stat)&(good)))
> > >  #define BAD_R_STAT		(BUSY_STAT   | ERR_STAT)
> > >  #define BAD_W_STAT		(BAD_R_STAT  | WRERR_STAT)
> > >  #define BAD_STAT		(BAD_R_STAT  | DRQ_STAT)
> > Assuming hdb is a CDROM/optical drive, then this change makes sense for
> > that. But I don't think it is a valid (good) change for regular ATA disks.
> >
> > A more complex patch is required, one which correctly handles each drive
> > type.

That patch was very ATAPI-specific, and would break other things.
It also would not correctly help anything in Justin's case.

-ml
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/