Re: [Ubuntu PATCH] acpi: Add IBM R60E laptop to proc-idle blacklist

[Randy Dunlap]

Matthew Garrett wrote:
> On Mon, Jun 19, 2006 at 08:33:33PM -0700, Andrew Morton wrote:
>>> +	{ set_max_cstate, "IBM ThinkPad R40e", {
>>> +	  DMI_MATCH(DMI_BIOS_VENDOR, "IBM"),
>>> +	  DMI_MATCH(DMI_BIOS_VERSION, "1SET70WW") }, (void*)1},
> 
>> It seems that every R40e in the world is in that table.
>>
>> Can/should we wildcard it?  From my reading of dmi_check_system(), we can use
>> "" in place of the "1SET..." string and it'll dtrt?
> 
> Wouldn't that result in every machine with "IBM" as the BIOS vendor 
> having their maximum c-state limited?

Yes.  DMI_MATCH() specifies substring matching, so _if we knew_
that any BIOS version that began with "1SET4", "1SET5", "1SET6",
or "1SET7" needed C-state limiting, the table could be made a lot
smaller.  But then it may need some exceptions, so just sticking
with full version strings seems reasonable to me.

~Randy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/