Re: Sanitise ethtool.h and mii.h for userspace.

[Jeff Garzik]

Linux Kernel Mailing List wrote:
> commit c3ce7e203af5d8eab7c3390fc991a1fcb152f741
> tree 43b0837c42a1deb5b0f87800bf6a5ed8eea2eafe
> parent 56142536868a2be34f261ed8fdca1610f8a73fbd
> author David Woodhouse <dwmw2@xxxxxxxxxxxxxxxxxxxxxxx> Sat, 29 Apr 2006 01:53:47 +0100
> committer David Woodhouse <dwmw2@xxxxxxxxxxxxx> Sat, 29 Apr 2006 01:53:47 +0100
>
> Sanitise ethtool.h and mii.h for userspace.
>
> They shouldn't be using 'u32' et al in structures which are used for
> communication with userspace. Switch to the proper types (__u32 etc).
>
> Signed-off-by: David Woodhouse <dwmw2@xxxxxxxxxxxxx>

How can reviewers make an informed decision, when you completely failed 
to note:

* This breaks the primary userspace user of this header, ethtool(8)
* The patch was NAK'd (and I don't even get a "Naked-by:" header :))
* Despite knowing all this for quite some time, no associated userspace 
fix patch has ever appeared.

If you are going to break stuff, AT LEAST TELL PEOPLE IN ALL CAPS ABOUT 
IT, rather than providing the highly deceptive description as above. 
And be courteous enough to help fix the breakage, if you please.

	Jeff, ethtool maintainer



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/