Re: [PATCH] Implement kasprintf

From: H. Peter Anvin
Date: Wed Jun 21 2006 - 00:29:44 EST


Andrew Morton wrote:
On Tue, 20 Jun 2006 23:04:44 -0400
Kyle McMartin <kyle@xxxxxxxxxxxxxxxx> wrote:

On Tue, Jun 20, 2006 at 04:57:16PM -0700, Jeremy Fitzhardinge wrote:
+char *kasprintf(gfp_t gfp, const char *fmt, ...)
+{
Why not just asprintf? We don't have ksprintf...
asprintf() doesn't take a gfp_t arg.


Or, more generally: if we change the API, change the name. kmalloc() is different from malloc() as it is invoked differently, as is kasprintf().

printk() was arguably a mistake, although it's semi-justified a posteori since it takes the priority pseudo-argument now.

-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/