Re: [PATCH 2/12] Support for larger maximum key size

[Michael Halcrow]

On Wed, Jun 21, 2006 at 09:49:57AM -0500, Timothy R. Chavez wrote:
> > -		    ECRYPTFS_MAX_ENCRYPTED_KEY_BYTES;
> > -	for (i = 0; i < auth_tok->session_key.encrypted_key_size; i++)
> > +	for (i = 0; i < (crypt_stat->key_size_bits / 8); i++)
> 
> Why don't you just do this particular calculation once?  Just looking
> down, you do this same calculation at least 4 other potential times.

Patch #10 in this set changes the keysize to bytes, so this is a
resolved issue.

Thanks,
Mike

Attachment: signature.asc
Description: Digital signature