[Patch] Ignored return value in drivers/mtd/chips/sharp.c

[Eric Sesterhenn]

hi,

coverity (id #10) spotted that we never reach the return ret; statement,
since ret never gets assigned a value except the 0 at
initialisation. I assume it was meant to hold the result
of sharp_write_oneword().

Signed-off-by: Eric Sesterhenn <snakebyte@xxxxxx>

--- linux-2.6/drivers/mtd/chips/sharp.c.orig	2006-06-21 22:03:45.000000000 +0200
+++ linux-2.6/drivers/mtd/chips/sharp.c	2006-06-21 22:04:48.000000000 +0200
@@ -342,7 +342,8 @@ static int sharp_write(struct mtd_info *
 			len--;
 			j++;
 		}
-		sharp_write_oneword(map, &sharp->chips[chipnum], ofs&~3, tbuf.l);
+		ret = sharp_write_oneword(map, &sharp->chips[chipnum],
+						ofs&~3, tbuf.l);
 		if(ret<0)
 			return ret;
 		(*retlen)+=j;


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/