Re: [patch] cleanup: kthread workqueue rename

[Coywolf Qi Hunt]

On Thu, Jun 22, 2006 at 04:13:16AM -0700, Andrew Morton wrote:
> On Thu, 22 Jun 2006 16:29:12 +0800
> Coywolf Qi Hunt <qiyong@xxxxxxxxx> wrote:
> 
> > -static struct workqueue_struct *helper_wq;
> > +static struct workqueue_struct *kthread_wq;
> 
> "helper" is better.  It's there to help kthread launching and that's all it
> does.  So "helper" is a more specific identification.


So "khelper_wq" should better be "helper_wq" too?

    khelper_wq = create_singlethread_workqueue("khelper");


'helper_wq' becomes [kthread] as shown in ps ax; I don't think it is a 'helper'.

    5 ?        S<     0:00 [khelper]
    6 ?        S<     0:00 [kthread]

That vague name makes me easily forget what I am looking at.  Please apply.

-- 
Coywolf Qi Hunt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/