Re: [PATCH] cardbus: revert IO window limit
From: Linus Torvalds
Date: Thu Jun 22 2006 - 12:17:45 EST
On Thu, 22 Jun 2006, Alan Cox wrote:
>
> Ar Iau, 2006-06-22 am 00:11 -0700, ysgrifennodd Andrew Morton:
> > There is something bad happening in there. Presumably, this patch will
> > break the ThinkPad 600x series machines again though.
> >
>
> Possibly not - remember Linus fixed the "hidden resources" problem with
> the PIIX bridge chips.
Right. The IBM thinkpad probably works (well, at least _that_ one:
there's tons of different Thinkpads, they have different cardbus
controllers, and at least one of them has some other problem).
However, changing the IO window size just hides the problem on the machine
that breaks this time around, and we should really fix _that_, rather than
hide it (because otherwise it will break again when we do something else
unrelated that just happens to change the order we do things in).
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/