Re: [PATCH] x86-64 build fix

[Andrew Morton]

Andi Kleen <ak@xxxxxx> wrote:
>
> On Thu, Jun 22, 2006 at 02:24:30PM -0700, Andrew Morton wrote:
> > Jeff Garzik <jeff@xxxxxxxxxx> wrote:
> > >
> > > As of last night, I still needed the Kconfig patch below to
> > > successfully build allmodconfig on x86-64.  I believe Andrew has the
> > > patch with a proper description and attribution, so I would prefer
> > > that he send it...
> > 
> > It was transferred from the -mm-only stuff and into the x86_64 tree, so
> > Andi owns it now.
> > 
> > I'll steal it back and will send it to Linus.
> 
> It's in my pile to eventually send, but so far nobody was able to explain
> to me why it is suddenly needed at all, so  I wasn't feeling
> very comfortable with it.
> 

urgh, we worked all this out several weeks ago.  Forget.

Looking at the patch, I guess the problem is the

config AGP
	default y if GART_IOMMU

which doesn't dtrt if you already have AGP=m.


The patch does this, instead:

config GART_IOMMU
	select AGP

which gives us AGP=y if GART_IOMMU=y.


I don't think Jeff has sent us an example .config, but I hit this a few
times too, before we fixed it.  I think this was all triggered by a Kconfig
change in the AGP tree, so you wouldn't have seen it, but -mm did.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/