Re: [PATCH] avoid cpu removal if busy revisited

From: KAMEZAWA Hiroyuki
Date: Thu Jun 22 2006 - 23:26:20 EST


On Thu, 22 Jun 2006 20:19:53 -0700
"Randy.Dunlap" <rdunlap@xxxxxxxxxxxx> wrote
>
> Maybe cpu_removal_migrate? I think that inverts the sysctl
> values though, like so:
>
> If cpu_removal_migrate == 1, all tasks are migrated by force.
> If cpu_removal_migrate == 0, cpu_hotremoval can fail because of
> not-migratable tasks (tasks bound to the target CPU).
>
> and init. the sysctl value to 1 as default.
>
Hmm, I did so at the fist touch but inverted to make default to be 0.
But if default value "1" is Okay, I'll invert. It makes sense.


> > +int moderate_cpu_removal;
>
> This is also declared (defined? I get those mixed up) in
> kernel/sysctl.c. One of them (this one I think) should be
> extern, but we prefer externs in a header file if possible.
>
>
Thanks, I'll fix and test carefully...
I need barrels of coffee today..

Thanks,
-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/