Re: cdrom support with thinkpad x6 ultrabay

[Kristen Carlson Accardi]

George Nychis wrote:
> any update on this? anyone else have a clue?
>
> Thanks!
> George
>
>
> Jeremy Fitzhardinge wrote:
>   
> > George Nychis wrote:
> >     
> > > I applied the acpi-dock patch that I specified, and that patch only, and
> > > i'm getting errors building:
> > >
> > > drivers/acpi/dock.c: In function 'dock_notify':
> > > drivers/acpi/dock.c:543: error: 'KOBJ_DOCK' undeclared (first use in
> > > this function)
> > > drivers/acpi/dock.c:543: error: (Each undeclared identifier is reported
> > > only once
> > > drivers/acpi/dock.c:543: error: for each function it appears in.)
> > > drivers/acpi/dock.c:562: error: 'KOBJ_UNDOCK' undeclared (first use in
> > > this function)
> > >
> > > Is there something else I need to apply that I am missing?
> > >   
> > >       
> > Kristen?
> >
> >    J
> >     
> > > Thanks!
> > > George
> > >
> > >
> > > Jeremy Fitzhardinge wrote:
> > >  
> > >       
> > > > George Nychis wrote:
> > > >    
> > > >         
> > > > > it successfully is applied, and i notice that CONFIG_ACPI_DOCK needs to
> > > > > be set, so I did a "make oldconfig" after applying the patch, expecting
> > > > > it to ask me whether or not i wanted to support it... it didn't.  So
> > > > > then I manually added "CONFIG_ACPI_DOCK=y" to the .config and built the
> > > > > kernel, but dock.o is never built... what else do i need to do?
> > > > >         
> > > > >           
> > > > Make sure you disable the (obsolete?) ACPI_IBM_DOCK stuff.
> > > >
> > > >    
> > > >         
> > > > > If i can't get hot swappable support yet, I might as well get what is
> > > > > supported for now so I can atleast use it sometimes :)
> > > > >
> > > > > Maybe this cry for help will spark someone to finish off the work on
> > > > > hot
> > > > > swapping the optical drive.
> > > > >         
> > > > >           
> > > > Yeah, I'm hoping all the work on power management in libata will make
> > > > things "just work" soon, but I think there's more to it.  When you press
> > > > the dock eject button, it really needs to go out to acpid, activate a
> > > > script to unmount any filesystems mounted off the device, and then poke
> > > > the ata layer to remove the device, before OKing the dock eject so the
> > > > hardware's "don't do that" light goes out.
> > > >
> > > > But in the meantime I'm having enough trouble getting plain old
> > > > suspend/resume reliable.
> > > >
> > > >    J
> > > >
> > > >     
> > > >         
Hi, sorry for the delay in responding - I am out of town at the moment 
and have sporadic access to email.

You are indeed missing a patch that you need:

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc5/2.6.17-rc5-mm3/broken-out/kevent-add-new-uevent.patch

If you have any PCI devices, you also need the patches to acpiphp:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17-rc5/2.6.17-rc5-mm3/broken-out/acpiphp-use-new-dock-driver.patch

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/