Re: [PATCH 08/21] gcc 4 fix

[Roman Zippel]

Hi,

On Fri, 23 Jun 2006, Al Viro wrote:

> On Fri, Jun 23, 2006 at 08:31:04PM +0200, zippel@xxxxxxxxxxxxxx wrote:
> > Fixes a "static qualifier follows non-static qualifier" error from gcc 4.
> > 
> > Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Roman Zippel <zippel@xxxxxxxxxxxxxx>
> 
> Broken.  Proper fix is to rename the function so that it wouldn't clash.

Well, I wouldn't call it broken, as both versions can never be compiled 
into the same kernel, but I don't care much how it's fixed.

Does anyone know the relationship between via-pmu.c and via-pmu68k.c? If 
it's intended to keep the differences small, a rename would be the wrong 
fix.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/