Re: Subject: [PATCH] reintegrate irqreturn.h into hardirq.h

From: Roman Zippel
Date: Sat Jun 24 2006 - 11:37:05 EST


Hi,

On Sat, 24 Jun 2006, Roland Dreier wrote:

> > -extern fastcall irqreturn_t handle_IRQ_event(unsigned int irq, struct pt_regs *regs,
> > +extern fastcall int handle_IRQ_event(unsigned int irq, struct pt_regs *regs,
> > struct irqaction *action);
>
> This seems like a step backwards: this changes the declaration of
> handle_IRQ_event() so it no longer matches the real definition.

Then it's better to change the definition back as well, we generally want
to avoid typedefs and this one is only a compatibility typedef meant for
drivers.

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/