Re: [PATCH] RTC: add rtc-ds1553 and rtc-ds1742 driver

[Atsushi Nemoto]

On Sun, 25 Jun 2006 11:55:25 +0200, Alessandro Zummo <alessandro.zummo@xxxxxxxxxxxx> wrote:
> > No, it is intentional.  If irq is not available, I want to fall back
> > into emulation in rtc-dev.c.
> 
>  maybe you can add a comment explaining this choice

Indeed.  Here it is.


Subject: RTC: Add a comment for ENOIOCTLCMD in ds1553_rtc_ioctl.

Signed-off-by: Atsushi Nemoto <anemo@xxxxxxxxxxxxx>

--- linux-2.6.17-mm2/drivers/rtc/rtc-ds1553.c	2006-06-25 23:28:24.387004000 +0900
+++ linux/drivers/rtc/rtc-ds1553.c	2006-06-25 23:31:00.156324096 +0900
@@ -226,7 +226,7 @@
 	struct rtc_plat_data *pdata = platform_get_drvdata(pdev);
 
 	if (pdata->irq < 0)
-		return -ENOIOCTLCMD;
+		return -ENOIOCTLCMD; /* fall back into rtc-dev's emulation */
 	switch (cmd) {
 	case RTC_AIE_OFF:
 		pdata->irqen &= ~RTC_AF;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/