Re: [PATCH] Kconfig for radio cards to allow VIDEO_V4L1_COMPAT

From: Sam Ravnborg
Date: Sun Jun 25 2006 - 14:24:00 EST


On Sun, Jun 25, 2006 at 01:40:49PM -0400, Jon Smirl wrote:
> In Kconfig all of the radio cards depend on VIDEO_V4L1. But V4L1 has
> been deprecated and replaced with V4L2. V4L2 offers a V4L1
> compatibility layer. Should the Kconfig for these devices be changed
> to depend on (VIDEO_V4L1. || VIDEO_V4L1_COMPAT)? I'm not the
> maintainer for this but they seem to build ok.

A cleaner approach would be to define a local symbol that spelled out
the dependencies. Something like

# Used because ....
config RADIO
depends on ISA && (VIDEO_V4L1 || VIDEO_V4L1_COMPAT)

config RADIO_CADET
tristate "ADS Cadet AM/FM Tuner"
depends on RADIO

The variable name RADIO is awfully bad but you get the idea..

Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/